Skip to content

[skip-changelog] Add CopySketch to the testsuite library #1879

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 19, 2022

Conversation

MatteoPologruto
Copy link
Contributor

CopySketch is a function that copies a sketch present in the "testdata" folder and copies it into the testing environment.

Please check if the PR fulfills these requirements

  • The PR has no duplicates (please search among the Pull Requests
    before creating one)
  • The PR follows
    our contributing guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)
  • UPGRADING.md has been updated with a migration guide (for breaking changes)

What kind of change does this PR introduce?

Infrastructure Enhancement

What is the new behavior?

CopySketch is a function that copies a sketch present in the testdata folder into the testing environment and returns its path.

Does this PR introduce a breaking change, and is titled accordingly?

No


See how to contribute

@MatteoPologruto MatteoPologruto added type: enhancement Proposed improvement topic: infrastructure Related to project infrastructure labels Sep 16, 2022
@MatteoPologruto MatteoPologruto self-assigned this Sep 16, 2022
@codecov
Copy link

codecov bot commented Sep 16, 2022

Codecov Report

Base: 36.68% // Head: 36.66% // Decreases project coverage by -0.01% ⚠️

Coverage data is based on head (880684a) compared to base (7d1916d).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1879      +/-   ##
==========================================
- Coverage   36.68%   36.66%   -0.02%     
==========================================
  Files         231      231              
  Lines       19680    19689       +9     
==========================================
  Hits         7219     7219              
- Misses      11633    11642       +9     
  Partials      828      828              
Flag Coverage Δ
unit 36.66% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
internal/integrationtest/arduino-cli.go 79.85% <0.00%> (-2.73%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@MatteoPologruto MatteoPologruto marked this pull request as ready for review September 16, 2022 14:13
CopySketch is a function that copies a sketch present in the "testdata"
folder and copies it into the testing environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: infrastructure Related to project infrastructure type: enhancement Proposed improvement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants